장부, 봉투 생성 시 상세 화면 이동 / 받은 장부 목록 쿼리 수정 #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangsooplus
approved these changes
May 15, 2024
| @@ -20,7 +20,7 @@ interface LedgerService { | |||
| @Query("title") title: String?, | |||
| @Query("categoryIds") categoryIdList: List<Int>?, | |||
| @Query("fromStartAt") fromStartAt: LocalDateTime, | |||
| @Query("toEndAt") toEndAt: LocalDateTime, | |||
There was a problem hiding this comment.
스웨거 보니까 toEndAt도 남아있던데, toStartAt이 toEndAt를 완전히 대체하는 것인가요? 아님 toStartAt이랑 toEndAt이랑 다른 쿼리인가요?
There was a problem hiding this comment.
완전히 바뀔 예정인걸로 알아요!
자세한 히스토리는 ... https://www.notion.so/489e952079c9405f9322a18eabe01084?pvs=4
요거 참고 부탁드림다
There was a problem hiding this comment.
아아 이거 관련이엇군요 친절한 링크제공 감사합니다
jinukeu
force-pushed
the
feature/move-create-envelope-ledger
branch
from
0c600db to
1db85b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Issue
🌱 Key changes
장부, 봉투 생성 시 상세 화면 이동 / 받은 장부 목록 쿼리 수정
✅ To Reviewers
📸 스크린샷